Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests problem: tests of psiturk_shell are basically no-op #473

Open
deargle opened this issue Mar 15, 2021 · 0 comments · May be fixed by #556
Open

tests problem: tests of psiturk_shell are basically no-op #473

deargle opened this issue Mar 15, 2021 · 0 comments · May be fixed by #556

Comments

@deargle
Copy link
Collaborator

deargle commented Mar 15, 2021

I just hit a problem with psiturk_shell.py's create_hit that surprised me because that function is ostensibly covered by a test case. Turns out that the test cases for psiturk_shell are basically useless because nearly nothing does self.perror, and the tests check for error output. Fixing the problem will require some extensive stubbing work for any shell call that makes an mturk call, which I'm not excited about after all the stubbing for amt_services_wrapper...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant