Logger repeats logs

[jacob-lee]

Logging is repeating messages. Perhaps handlers are being added more than once?

Python: 3.8
Psiturk: github master today
Reproduction:

conda env create --name testloggerrepeat python=3.8
conda activate testloggerrepeat
pip install git+https://github.com/NYUCCL/psiTurk.git
psiturk-setup-example;

# Either modify logging level, or change level logged in my_custom_view's; I did the latter

cd psiturk-example; 
psiturk -e 'server on'; 
curl http://127.0.0.1:22362/my_custom_view
cat server.log

Correct output:
[2020-07-25 14:10:33 -0400] [15478] [ERROR] Reached /my_custom_view

Actual output:

[2020-07-25 14:10:33 -0400] [15478] [ERROR] Reached /my_custom_view
2020-07-25 14:10:33,929 Reached /my_custom_view

[deargle]

The first one is a log from gunicorn, and the second is from flask. I wrestled with this again for a while with a recent PR (https://github.com/NYUCCL/psiTurk/pull/483/files), but I think I decided it was necessary to have both, I can't remember. But flask routes need to be able to log, and so does gunicorn.

[jacob-lee]

Can they be separated into two log files then?

[deargle]

Not for situations that need stream logging, like cloud providers. I wish I had kept notes on what I saw during that PR, I remember having a lot more insight into what was going on and why...

…

On Mon, May 3, 2021, 9:51 PM jacob-lee ***@***.***> wrote: Can they be separated into two log files then? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#432 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAI6Y7K7A4UXNNYVCMD6UWLTL5VNVANCNFSM4PHSPX2A> .

[jacob-lee]

Here are a couple ideas. - preface log entries with source (e.g. gunicorn, flask, etc.); am pretty sure I've done something similar before. - allow different logging levels for gunicorn and flask. Seems like we'd only want warning and above most of the time for gunicorn On Tue, May 4, 2021 at 12:44 AM Dave Eargle ***@***.***> wrote:

…

Not for situations that need stream logging, like cloud providers. I wish I had kept notes on what I saw during that PR, I remember having a lot more insight into what was going on and why... On Mon, May 3, 2021, 9:51 PM jacob-lee ***@***.***> wrote: > Can they be separated into two log files then? > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#432 (comment)>, or > unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAI6Y7K7A4UXNNYVCMD6UWLTL5VNVANCNFSM4PHSPX2A > > . > — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#432 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAM5SQOPXXJPIRTJ2JIPLQ3TL53RTANCNFSM4PHSPX2A> .