New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect thumb joints nomenclature #112

Open

andreh1111 opened this issue Oct 25, 2023 · 1 comment

Labels

Contributor

andreh1111 commented Oct 25, 2023

Hi,
I think the myoHand nomenclature related to the thumb joints (cmc_abduction, cmc_flexion, mp_flexion, ip_flexion) isn't correct for two reasons:

for all the other fingers, the word after "_" is what happens toward the maximum value of qpos (e.g., when mcp2_flexion is max, the index finger is flexed) while the thumb joints are extended when _flexion is max. The same logic is for _abduction.
cmc_abduction and cmc_flexion are reversed.

Vittorio-Caggiano added the enhancement label

Collaborator

Vittorio-Caggiano commented Nov 1, 2023

Hi @andreh1111
thanks for pointing to this issue. We will update the hand model after the MyoChallenge.

andreh1111 mentioned this issue

Addition of the Adductor Pollicis muscle #140

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment