Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: directive(s) not present in typeDefs when using buildTypeDefsAndResolvers(Sync) #1399

Open
carlocorradini opened this issue Dec 17, 2022 · 9 comments
Assignees
Labels
Community 👨‍👧 Something initiated by a community Documentation 📖 Issues about docs

Comments

@carlocorradini
Copy link
Contributor

I think we should add to the docs that buildTypeDefsAndResolvers and buildTypeDefsAndResolversSync do not have any directive(s) in typeDefs.

@MichalLytek MichalLytek added Community 👨‍👧 Something initiated by a community Documentation 📖 Issues about docs labels Dec 18, 2022
@MichalLytek
Copy link
Owner

We could even replace the printSchema with the function from graphql tools to have directives printed.

@carlocorradini
Copy link
Contributor Author

Therefore, add graph-tools as a dependency?
This could solve all directive(s) issues :)

@MichalLytek
Copy link
Owner

Yes, until we have a plugin system and modular packages, we need to download everything even if not needed for most of the users 🤔

@carlocorradini
Copy link
Contributor Author

Any idea for the implementation of a plugin/extension system?

@MichalLytek
Copy link
Owner

Started 2 years ago a complete rewrite from scratch 😅

@carlocorradini
Copy link
Contributor Author

Yup, saw it!
All the ideas are implemented in v2? Or you simply added them as idea in GitHub project?

@MichalLytek
Copy link
Owner

The board was up to date with the state of my local branch. Now I think I would need to update lerna to nx, npm workspaces, etc. 😄

@carlocorradini
Copy link
Contributor Author

If I can help, I love TypeGraphQL and I'm using it in my Master's Thesis (and a lot of other projects too), so... yeah, TypeGraphQL all the way 😂

Several months ago I may have agreed with you  for ditching Lerna with something else but now Lerna is super carried and heavily maintained.
Do you want to use Lerna for packages (i.e., plugins, TypeGraphQL ecosystem), I've also used npm workspaces, and please let me know if I can assist... 

@carlocorradini
Copy link
Contributor Author

Moreover, I think that could be super useful if we create a TypeGraphQL chatroom (i.e., Discord, Slack, etc.) for thoughts, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community 👨‍👧 Something initiated by a community Documentation 📖 Issues about docs
Projects
None yet
Development

No branches or pull requests

3 participants
@MichalLytek @carlocorradini and others