-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Will MFE be also published to the Microsoft Store? #36
Comments
@FireCubeStudios said he wants to do that. |
ah nice 👍🏻 |
Well MSIX packaging is super broken so probably a damn long time. |
It works when you build it from command-line, this is Visual Studio's bug. |
Literally everything breaks. |
what do you mean, it works fine when I build it from command-line. |
The way we have now is just kind of a workaround. |
Yes, I thought you mean that's broken too |
It would be also awesome if you could release it on chocolatey. |
Does Chocolatey support MSIX tho, since having to create another installer would be kind of crazy. |
@vedantmgoyal2009 I think the problem currently with adding it to Winget is that the The best solution to this would be to course, publish it to the Microsoft Store where they would sign it themselves, which brings us back to this issue. So this needs to be resolved first before adding it to anything else (Winget, Chocolatey). Side note: MFE is already in Scoop (uses the portable version), and is now being updated to the new version in ScoopInstaller/Extras#8181. |
Cool, I'm being famous For winget I can create an Inno Setup wizard, winget supports installers too, not just msix. |
MSIX works, don't create another installer.
And yes, it supports MSIX. See Windows Terminal package. |
Unfortunately the way we package MSIX is super broken. None of our attempts have been accepted by the Store so far. |
I suggest we fix that first. |
You suggest but the problem is it can't be fixed. We can't publish a xaml island to store. We are waiting for App SDK 1.1 release to migrate to WinUI 3. |
There is one way I know: Use VS 16.9 |
Another question is why is MFE still using .NET Core? aren't we supposed to be in .NET 6 already? (and .NET Core EOL is in a few months.) |
No, XAML Islands makes it impossible for us to use .NET 5 or any newer version. We could try moving to .NET Framework though. |
.NET 5 removed builtin WinRT support from compiler, so we need a custom compiled version of CsWinrt that supports XAML Islands, or we need to move to WinUI 3. I tried to use .NET Framework 4.8, it supports XAML Islands but WinUI 2.8 was broken on it. We planned to move to WinUI 3 after AppSDK 1.1 release, because this version adds Mica support so we can keep Mica backdrop on background of Settings page. |
But we will have to sacrifice good rendering and fast UI though. |
WinUI 3 is really that slow? |
And also MS official docs says there is a "slight disadvantage" in performance in WinUI 3: https://docs.microsoft.com/en-us/windows/apps/windows-app-sdk/migrate-to-windows-app-sdk/what-is-supported |
still there's no other choice, except ModernWpf or C++. |
ModernWpf doesn't have WinUI 2.6+ styles |
You can re-enable WinRT in .NET 6 if you target msix packaging. |
We can write an UWP app with a desktop bridge, then we can put Settings UI in UWP app and tray icon and MFE's actual logic in a win32 app. In this case we will lose ability to use modern context menu for tray icon but we don't need XAML Islands and we can publish app to store easily, also it fixes context menu bugs on Windows 10. |
Don't think it's possible to do that though. |
I've already seen apps with this approach |
I was talking about the context menu.
|
uh Ig we just have to use classic context menu, I said we lose ability to use modern context menu. |
Update: @dongle-the-gadget started working on C++ version of original MFE (we already have an unofficial C++ win32-based version with basic abilities of MFE by @rounk-ctrl, see here). I'll help him as soon as I have free time. There will be no problem for publishing that C++ version on store, except a valid certificate that @FireCubeStudios said he would help. |
For some clarity, rounk-ctrl's port is unofficial. Mine is currently in private development (the repo is in the MicaForEveryone organization). |
We are still focused on getting at least one version on the Microsoft Store though…
And we want it to be MSIX.
|
Portable software in zip files? |
Hmm, okay. microsoft/winget-cli#140 would have to be solved first before the portable zip version can be added to Winget. |
Creating an installer for winget won't be that hard. I can do that already in like 5 minute. |
Going back to #36 (comment), you already have an MSIX installer. Why not just use that? You only need a certificate for it. |
I don't have a valid certificate and a xaml island mixed with .NET Core can't be uploaded to store. |
You said @FireCubeStudios would help on this.
Sure, not on the store, but allowed on Winget (I don't see a policy disallowing it; just as long as it installs successfully). |
@FireCubeStudios assist us in uploading the app to Microsoft Store. They don’t have a valid cert issued by a trusted CA.
|
I wonder if we can upload C++ version to store, it still contains compiled .NET Native code. Only applicable approach is using desktop bridge or using WinUI 3.0. Right now main app is .NET Core app and we have a helper UWP app for UI. In desktop bridge main app is UWP and there's a helper win32 executable to do stuff outside of UWP sandbox. |
Oh, alright. How about the possibility of migrating to WinUI 3 now? WindowsAppSDK 1.1 has already been released for while, so you can keep Mica backdrop now. |
I don't think the C++ version has any C# code currently, and I genuinely don't think C# WinRT Components would just fail certification. |
There are still quite a lot of problems with WinUI 3, particularly with rendering and out of bounds context menus. |
With desktop bridge we have to use legacy context menu too, same with WinUI 3.0 |
Aurora, Inkscape? (all .NET Core 3.1 compiled using VS 16.9) |
I remembered the wrong name... It's Ink Workspace |
IIRC the dev of Aurora has tweeted publicly about a version of it that supposedly uses Islands. |
Have you considered using this: https://github.com/lepoco/wpfui Or this: https://github.com/Kinnara/ModernWpf |
I turned them down. |
I think that’s no good…
|
It'll be possible to put MFE to Store once we switch to C++. Problem is we have a UWP helper project that's not our app's main project, and it's in C#. We can put MFE to store even if we don't fully switch to C++ and just rewrite the UWP helper in C++. |
The bug report has been left abandoned for quite some time though, and also .NET 3 would reach EoS within 2 months. |
Any plans for this? 😁
The text was updated successfully, but these errors were encountered: