Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Securities are not always updated when those aren't direct dependencies #5

Open
omarlopesino opened this issue Mar 17, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@omarlopesino
Copy link
Member

omarlopesino commented Mar 17, 2023

It happened that the script wasn't able to update the drupal core latest security, when the project has drupal/core-recommended installed.

It looks like as not the complete metapackage has been updated, it is not possible to independently upgrade drupal core.

Steps to reproduce

  • Have a site with Drupal 9.4.11 or lower / 9.5.4 or lower / 10.0.4 or lower , but with drupal/core-recommended in the requirements.
  • Run drupal-updater --security
@omarlopesino omarlopesino added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Apr 19, 2023
@omarlopesino
Copy link
Member Author

After thinking about it I conclude that drupal updater must rely on the constraints, otherwise, modules can be calculated automatically.

@omarlopesino
Copy link
Member Author

After thinking again a good solution would be:

  • Detect if a security package is a transitive dependency, then detect the direct dependency, and then update that direct dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant