Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate docker compose file names to Compose V2 #141

Open
omarlopesino opened this issue Mar 25, 2024 · 3 comments
Open

Migrate docker compose file names to Compose V2 #141

omarlopesino opened this issue Mar 25, 2024 · 3 comments

Comments

@omarlopesino
Copy link
Member

omarlopesino commented Mar 25, 2024

According to new compose versions, the files must start with compose, instead of starting with docker-compose as before: https://docs.docker.com/compose/compose-application-model/

The default path for a Compose file is compose.yaml (preferred) or compose.yml that is placed in the working directory. Compose also supports docker-compose.yaml and docker-compose.yml for backwards compatibility of earlier versions. If both files exist, Compose prefers the canonical compose.yaml.

We should change the file names to meet the new standard.

Pull requests related:

Metadrop/drupal-boilerplate-assistant#1
#140

@omarlopesino
Copy link
Member Author

@rsanzante may you review the pull requests?

@rsanzante
Copy link
Member

Changes requested in the assistant PR, see Metadrop/drupal-boilerplate-assistant#1 (review)

@omarlopesino
Copy link
Member Author

All changes requested in the feedback have been done and both the assistant and the boilerplate are ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants