Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'Simulation' reference inside Service Centers #36

Open
MathRPG opened this issue Aug 26, 2023 · 0 comments
Open

Remove 'Simulation' reference inside Service Centers #36

MathRPG opened this issue Aug 26, 2023 · 0 comments
Assignees
Labels
refactor Refactoring and re-engineering the implementation

Comments

@MathRPG
Copy link
Owner

MathRPG commented Aug 26, 2023

A step toward command/query separation, 'Simulation' is reference inside service centers to schedule (and remove) events. It would be better for the methods to return all new events, or perhaps a 'command' object with addition and removal parameters.

It is debatable if events should be removed from the simulation queue at all, or if service centers should merely ignore invalid events. If the latter, removal does not need to be supported in the new interface.

This would also aid testability, since then service centers could be tested in isolation, without needing an entire 'simulation' object around them.

@MathRPG MathRPG added the refactor Refactoring and re-engineering the implementation label Aug 26, 2023
@MathRPG MathRPG added this to the Application Optimization milestone Aug 26, 2023
@MathRPG MathRPG self-assigned this Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring and re-engineering the implementation
Projects
None yet
Development

No branches or pull requests

1 participant