Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method overload for ShowDialog extension with identifier #3503

Open
Myliak opened this issue Mar 26, 2024 · 3 comments
Open

Add method overload for ShowDialog extension with identifier #3503

Myliak opened this issue Mar 26, 2024 · 3 comments
Assignees
Labels
enhancement Waiting on feedback Additional information is needed. Stale items with this label may be closed.

Comments

@Myliak
Copy link

Myliak commented Mar 26, 2024

Is your feature request related to a problem? Please describe.
It's rather simple problem, when iterating through xaml object tree, it would be nice to define identifier which must be on found DialogHost, so if multiple are present, it chooses correct one

Describe the solution you'd like
Create an overload method that accepts string identifier, exactly as is in DialogHost.ShowDialog

Describe alternatives you've considered
I don't think there are any, except for using only one dialoghost (so I take this as low prio)

@Myliak Myliak added enhancement evaluation required Items is pending review or evaluation by the team labels Mar 26, 2024
@MichelMichels
Copy link
Member

Could you explain a bit better what you'd like to be added? The code in DialogHost.Show(...) already accepts an identifier. I think I'm missing some information.

@MichelMichels MichelMichels self-assigned this Mar 31, 2024
@MichelMichels MichelMichels added Waiting on feedback Additional information is needed. Stale items with this label may be closed. and removed evaluation required Items is pending review or evaluation by the team labels Mar 31, 2024
@Myliak
Copy link
Author

Myliak commented Apr 2, 2024

No problem, there are two variations of how to open Dialog window in code:

  1. DialogHost.Show(...) as you said - Wiki
  2. .Show(...) Extension, which does not have the identifier overload - Wiki

The second one is the one I would like to add overload to :)

Copy link
Contributor

github-actions bot commented May 3, 2024

This issue is marked stale because it has been open 30 days with no activity. Remove stale label or update the issue, otherwise it will be closed in 14 days.

@github-actions github-actions bot added the Stale Issues and PRs that have not had activity for a while are marked with this label. label May 3, 2024
@MichelMichels MichelMichels removed the Stale Issues and PRs that have not had activity for a while are marked with this label. label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Waiting on feedback Additional information is needed. Stale items with this label may be closed.
Projects
None yet
Development

No branches or pull requests

2 participants