Saga Activity Exception Handler and Set Retry Policy

[muratyuceer]

Hello,

The code below successfully catches errors during the activity execution by blocking the publish and preventing the transition to the "OrderCreateRequested" state. It then updates the status to "OrderCreateRequestFailed" successfully. However, it does not retry. I want it to fall into the Catch block after retrying 3 times. How can I do this?

    Initially(
        When(CreateOrderRequest)
            .Then(context =>
            {
                context.Saga.UserId = context.Message.UserId;
                context.Saga.CreatedOnUtc = DateTime.UtcNow;
            })
            .Activity(x => x
                .OfType<OrderCreateRequestActivity>()
                .Publish(context => new OrderCreateRequestedEvent(context.Message.OrderId, context.RequestId!.Value, context.ResponseAddress!.ToString()))
                .TransitionTo(OrderCreateRequested)
            )
            .Catch<Exception>(x => x
                .TransitionTo(OrderCreateRequestFailed)
            )
     );

[phatboyg]

.Retry(r => r.Intervals(10, 10, 10), x => x
    .Then(context =>
    {
        context.Saga.AttemptCount++;
        throw new IntentionalTestException("Time to crash");
    })),

[muratyuceer]

Hi Chris, i tried like below but it does not repect even interval count

    Initially(
        When(CreateOrderRequest)
            .Then(context =>
            {
                context.Saga.UserId = context.Message.UserId;
                context.Saga.CreatedOnUtc = DateTime.UtcNow;
            })
            .Activity(x => x
                .OfType<OrderCreateRequestActivity>()
                .Publish(context => new OrderCreateRequestedEvent(context.Message.OrderId, context.RequestId!.Value, context.ResponseAddress!.ToString()))
                .TransitionTo(OrderCreateRequested)
            )
            .Retry(r => r.Intervals(2, 2, 2), x => x
                         .Then(context =>
                         {
                             //context.Saga.AttemptCount++;
                             throw new Exception("Time to crash");
                         })
                        .Catch<Exception>(x => x
                            .TransitionTo(OrderCreateRequestFailed)
                        )
            )
     );

[phatboyg]

Initially(
    When(CreateOrderRequest)
        .Then(context =>
        {
            context.Saga.UserId = context.Message.UserId;
            context.Saga.CreatedOnUtc = DateTime.UtcNow;
        })
        .Retry(r => r.Intervals(2, 2, 2), r => r
            .Activity(x => x.OfType<OrderCreateRequestActivity>())
            .Publish(context => new OrderCreateRequestedEvent(context.Message.OrderId, context.RequestId!.Value, context.ResponseAddress!.ToString()))
            .TransitionTo(OrderCreateRequested)
        )
        .Catch<Exception>(x => x
            .TransitionTo(OrderCreateRequestFailed)
        )
 );

[muratyuceer]

I tried it this way too, but on the first error, it is caught directly by the catch block without retrying, and its status is changed.

    Initially(
        When(CreateOrderRequest)
            .Then(context =>
            {
                context.Saga.UserId = context.Message.UserId;
                context.Saga.Symbol = context.Message.Symbol;
                context.Saga.Side = context.Message.Side;
                context.Saga.RequestedCashAmount = context.Message.RequestedCashAmount;
                context.Saga.RequestedQuantity = context.Message.RequestedQuantity;
                context.Saga.SagaRequestId = context.RequestId!.Value;
                //İşlemi başlatan user'a hangi queue üzerinden cevap vereceğini temsil eder.
                context.Saga.SagaResponseAddress = context.ResponseAddress!.ToString();
                context.Saga.CreatedOnUtc = DateTime.UtcNow;
            })
            .Activity(x => x
                .OfType<OrderCreateRequestActivity>()
                .Publish(context => new OrderCreateRequestedEvent(context.Message.OrderId, context.RequestId!.Value, context.ResponseAddress!.ToString()))
                .TransitionTo(OrderCreateRequested)
            )
            .Retry(r => r.Intervals(2, 2, 2), x => x
                 .Then(context =>
                 {
                     //context.Saga.AttemptCount++;
                     throw new Exception("Time to crash");
                 })
            )
            .Catch<Exception>(x => x
                .TransitionTo(OrderCreateRequestFailed)
            )
     );

My activity for test like below

public class OrderCreateRequestActivity(
IOrderService orderService,
ILogger logger) :
IStateMachineActivity<OrderStateInstance, CreateOrderRequest>
{
public void Probe(ProbeContext context)
{
context.CreateScope("create-order-activity");
}

public void Accept(StateMachineVisitor visitor)
{
    visitor.Visit(this);
}

public async Task Execute(
    BehaviorContext<OrderStateInstance, CreateOrderRequest> context,
    IBehavior<OrderStateInstance, CreateOrderRequest> next)
{
    throw new Exception("!!!!!!!!!!!It only triggers once here!!!!!!!!!!!!!");

    try
    {
        await next.Execute(context).ConfigureAwait(false);
    }
    catch (Exception)
    {
        var endpoint = await context.GetSendEndpoint(new Uri(context.Saga.SagaResponseAddress));

        await endpoint.Send(new PublishCreateOrderResponseDto(
            context.Message.OrderId, false, false), 
            r => r.RequestId = context.Saga.SagaRequestId, 
            context.CancellationToken);

        throw;
    }
}

public async Task Faulted<TException>(
    BehaviorExceptionContext<OrderStateInstance, CreateOrderRequest, TException> context,
    IBehavior<OrderStateInstance, CreateOrderRequest> next)
    where TException : Exception
{
    //never trigger here (not important)
     
    var endpoint = await context.GetSendEndpoint(new Uri(context.Saga.SagaResponseAddress));

    await endpoint.Send(new PublishCreateOrderResponseDto(
        context.Message.OrderId, false, false), 
        r => r.RequestId = context.Saga.SagaRequestId, 
        context.CancellationToken);

    await next.Faulted(context);
}

}

[phatboyg]

Updated my example above. Not sure what you aren't getting.

[muratyuceer]

Its, worked