Fix ruleSet parameter omission in AddRule overloads #3892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a contributor agreement from @kamranrauf75 |
|
Thank you for your contribution. Could you please also add a test for this bug. Thanks again! |
|
@kamranrauf75 Friendly reminder to please add tests for this PR to be merged. |
|
@StefanOssendorf Thank you for reviewing my pull request. I understand the importance of unit tests, but the change I've made is quite minor, and tests for such a change doesn't make much sense to me. But still I'll try to add relevant tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3803
Bug: Add lambda rule handler does not use the given ruleSet and adds the rule to the default rule set