Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextSeparator = ", " for concatenating errors #2925

Closed
michaelcsikos opened this issue May 6, 2022 · 1 comment · Fixed by #3942
Closed

TextSeparator = ", " for concatenating errors #2925

michaelcsikos opened this issue May 6, 2022 · 1 comment · Fixed by #3942
Assignees
@Freelancingonupwork
Labels
kind/enhancement

Comments

@michaelcsikos
Copy link

The standard validation error messages such as [Required] are proper sentences ending with a . and I think this is good practice. Csla.Blazor.PropertyInfo assumes error messages won't end with a . using ", " to concatenate errors, so you end up with:

image

Should TextSeparator = " " or perhaps be a public static string TextSeparator { get; set; } instead?
@rockfordlhotka
Copy link
Member

It seems like something someone could set, and perhaps the default should be " ".

@Freelancingonupwork Freelancingonupwork mentioned this issue May 15, 2024
Merged
Freelancingonupwork added a commit to Freelancingonupwork/csla that referenced this issue May 15, 2024
@Freelancingonupwork
Merge branch 'main' into MarimerLLC#2925-TextSeparator-for-concatenat…
f3ccf2a 
…ing-errors/main
rockfordlhotka added a commit to Freelancingonupwork/csla that referenced this issue May 17, 2024
@rockfordlhotka
Merge branch 'main' into MarimerLLC#2925-TextSeparator-for-concatenat…
9e7b131 
…ing-errors/main
rockfordlhotka added a commit to Freelancingonupwork/csla that referenced this issue May 20, 2024
@rockfordlhotka
Merge branch 'main' into MarimerLLC#2925-TextSeparator-for-concatenat…
e9870fb 
…ing-errors/main
rockfordlhotka added a commit that referenced this issue May 20, 2024
@Freelancingonupwork @StefanOssendorf @rockfordlhotka
#2925 text separator for concatenating errors/main (#3942)
9df9274 
* Add DisplayIndex Property to Business Rules

* Test

* Update

* Text separator for concatenating errors

* Chnages

---------

Co-authored-by: Stefan Ossendorf <StefanOssendorf@users.noreply.github.com>
Co-authored-by: Mayur Kasidariya <mayur.kasidariya@potenzaglobalsolutions.com>
Co-authored-by: Rockford Lhotka <rocky@lhotka.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Freelancingonupwork Freelancingonupwork

Labels
kind/enhancement
Projects
CSLA Version 9.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2925 text separator for concatenating errors/main Freelancingonupwork/csla
3 participants
@rockfordlhotka @michaelcsikos @Freelancingonupwork