Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we remove nlsp settings? #4132

Closed
ChristianChiarulli opened this issue May 6, 2023 · 9 comments
Closed

Should we remove nlsp settings? #4132

ChristianChiarulli opened this issue May 6, 2023 · 9 comments
Labels
question Further information is requested stale

Comments

@ChristianChiarulli
Copy link
Member

I forget if I've asked this before

@ChristianChiarulli ChristianChiarulli added the question Further information is requested label May 6, 2023
@ChristianChiarulli ChristianChiarulli pinned this issue May 6, 2023
@quantumfate
Copy link

yes it barely supports anything useful

@chaozwn
Copy link

chaozwn commented May 23, 2023

i think it's a good idea to remove nlsp settings.

@meijieru
Copy link
Contributor

It enables an easy way to customize the lsp per project.

@chaozwn
Copy link

chaozwn commented May 27, 2023

It enables an easy way to customize the lsp per project.

hi, guy. can you tell the way how to customize the lsp.

@nieomylnieja
Copy link
Contributor

yes it barely supports anything useful

that's a very shallow statement, bear in mind it's used to configure LSP servers themselves, not the nvim wrapper for them (like filetype options). It supports all the major LSPs out there, so again, not really sure what are you basing your opinion on. As @meijieru mentioned, it also allows an easy way to manage per project config.
It is definitely not sth and average user would ever use though, maybe it's a bit of an overkill to have it maintained within LunarVim. On the other hand I'm not sure how much of a pain would it be to add it outside of the lsp setup within lvim core, If it's to be removed, I'd definitely explain in the example plugin configurations on how to configure it.

@LostNeophyte
Copy link
Member

LostNeophyte commented May 31, 2023

pros and cons of removing it that I can think of at the moment:

  • it's barely maintained, the readme still uses lsp-installer in the examples instead of mason, there's a two month old pr to fix that with no comments from the maintainer
  • most users probably don't know how and don't use it

cons:

  • breaking change
  • I prefer nlsp-settings over our way of configuring lsp servers, it requires way less effort and there's completion

we could switch to folke/neoconf instead

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 50 days with no activity.

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 50 days with no activity.

@github-actions github-actions bot added the stale label Sep 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested stale
Projects
None yet
Development

No branches or pull requests

6 participants