Return command name as UCI response after successful parameter setting. #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooskagh
requested changes
Jun 30, 2022
| @@ -139,6 +139,9 @@ void UciLoop::RunLoop() { | |||
| // Ignore empty line. | |||
| if (command.first.empty()) continue; | |||
| if (!DispatchCommand(command.first, command.second)) break; | |||
| else { | |||
| SendResponse(std::string("executed ") + command.first); | |||
There was a problem hiding this comment.
It doesn't do what was required, what was needed is info string command.
Also the main thing to fix is error part, not successful execution.
For the success part, we (potentially) only need it for setting variables, not for all UCI commands.
There was a problem hiding this comment.
Actually, after some thinking and reading discord history, I'm sure we should only report error case, not setting variables part.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1598. But still unsure what to return as a confirmation.