Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currently, there is a problem with subset = '_all' for opsimversion = 'lsstv4' #288

Open
rbiswas4 opened this issue Nov 5, 2018 · 0 comments · May be fixed by #289
Open

Currently, there is a problem with subset = '_all' for opsimversion = 'lsstv4' #288

rbiswas4 opened this issue Nov 5, 2018 · 0 comments · May be fixed by #289
Assignees
@rbiswas4
Labels
bug

Comments

@rbiswas4
Copy link
Member

rbiswas4 commented Nov 5, 2018

Fix this/
@rbiswas4 rbiswas4 added the bug label Nov 5, 2018
@rbiswas4 rbiswas4 self-assigned this Nov 5, 2018
rbiswas4 added a commit that referenced this issue Nov 5, 2018
@rbiswas4
Fix the hardcoded propID variable to version dependent propID.
2b0fb28 
Actually introduced new static method `get_propIDVals` making the
former `propIDVals` method defunkt. A name change was useful and I
fixed this in the new method. The old one has not been removed but
probably could be.

TODO:
- remove the old function
- Check the method `get_propIDDict` which does not seem to use OpSimVars
  and hopefully update it.
- Check the number of methods that can be removed.

Fixes #288
	modified:   opsimsummary/opsim_out.py
	modified:   opsimsummary/version.py
@rbiswas4 rbiswas4 linked a pull request Nov 5, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbiswas4 rbiswas4

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the hardcoded propID variable to version dependent propID. LSSTDESC/OpSimSummary
1 participant
@rbiswas4