Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify variables for right ascension and declination. #264

Open
cnsetzer opened this issue Aug 9, 2018 · 1 comment
Open

Clarify variables for right ascension and declination. #264

cnsetzer opened this issue Aug 9, 2018 · 1 comment

Comments

@cnsetzer
Copy link
Member

cnsetzer commented Aug 9, 2018

At present it is not entirely clear that _ra and _dec in the summary tables should be the variables used which should be agnostic of OpSim version. This could be clarified so that users do not accidentally use fieldRA/ditheredRA assuming these are the correct columns which undergo unit conversion etc.

@rbiswas4
Copy link
Member

@cnsetzer As we discussed, it is not usually a good idea to have underscored variables fo users. Indeed, when developing this, these variables were meant to be internal to OpSimSummary and not used by the user at all. A user was expected to use the syntax described here to obtain cadences.

Since you find this useful, it might be good to define public variables related to _ra and _dec but following the broader LSST convention, must be in degrees . Do you think this will serve your purpose? I can then add these (even though there is some extra memory usage in pandas).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants