Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kompute.hpp - how to generate and why? #288

Open
COM8 opened this issue May 18, 2022 · 0 comments
Open

Kompute.hpp - how to generate and why? #288

COM8 opened this issue May 18, 2022 · 0 comments

Comments

@COM8
Copy link
Contributor

COM8 commented May 18, 2022

I noticed Kompute.hpp contains just a copy of all other headers.
Is there any reason for not doing something like this:

#pragma once

#include <Tensor.hpp>
#include <Sequence.hpp>
// ...

Since then the preprocessor will take over the task of expanding all #include macros for us.
An example of that can be found here: https://github.com/libcpr/cpr/blob/master/include/cpr/cpr.h

Then we also get rid of all the logic for compiling either Kompute as a single header via KOMPUTE_OPT_BUILD_SINGLE_HEADER.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant