Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keymap files used to layout Dvorak Branch 3.0 (v1-22-24) #397

Open
hh opened this issue Mar 1, 2024 · 5 comments
Open

keymap files used to layout Dvorak Branch 3.0 (v1-22-24) #397

hh opened this issue Mar 1, 2024 · 5 comments

Comments

@hh
Copy link

hh commented Mar 1, 2024

It seems the default factory image is here:
https://kinesis-ergo.com/download/adv360-pro-factory-default-branch-3-0-v1-16-24-commit-ddcdb88/

And the factory Dvorak image is here:
https://kinesis-ergo.com/download/adv360-pro-dvorak/

I'd like to have a branch or commit that includes the Pre-Programmed Dvorak layout.
This would make an easier starting point for customization.

@KinesisCorporation
Copy link
Owner

Thanks for the suggestion, this is under evaluation. The primary concern is it could make it more complicated/cumbersome for all the non-Dvorak users, but if there is an easy way to do it and support it on an ongoing basis that could make sense.

@huber-th
Copy link
Contributor

huber-th commented Mar 2, 2024

@KinesisCorporation an easy way to achieve this, which doesn't require another branch or commit, would be to include other keyboard layouts in the config folder of the repository in a separate keymap file. e.g. dvorak.keymap, colemak.keymap, colemak-dh.keymap etc. while keeping the default qwerty in adv360.keymap to avoid issues with existing forks.

For example if you added your Dvorak keymap as dvorak.keymap then all users who wish to use that layout would have to do in their own repositories is update adv360_left.keymap and adv360_right.keymap to include the dvorak.keymap instead of adv360.keymap.

/*
*
* Copyright (c) 2021 Polarity Works
* SPDX-License-Identifier: MIT
*
*/

#include "dvorak.keymap"

This would allow you to publish alternative keymap layouts without breaking current user's repositories and at the same time offer alternative layouts for users with minimal effort to switch between them.

I have done this in my own repository to test and verify by moving my customized keymap into a personal.keymap file and adjusted the includes in adv360_left.keymap and adv360_right.keymap.

@ReFil
Copy link
Collaborator

ReFil commented Mar 2, 2024

It's worth noting doing so would break the online keymap configurator

@hh
Copy link
Author

hh commented Mar 2, 2024 via email

@huber-th
Copy link
Contributor

huber-th commented Mar 2, 2024

It's worth noting doing so would break the online keymap configurator

That's a good point to note. That seems more an issue of making sure there are clear instructions of how to use alternative layouts provided in a separate file.

Instead of updating the adv360_left.keymap and adv360_right.keymap users who wish to use the online editor can rename or delete the stock adv360.keymap and rename the alternative layout keymap file to adv360.keymap?

Or simply copy the full file content from one to the other file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants