Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay flow start until sufficient volume is observed #77

Open
mik3y opened this issue Mar 31, 2014 · 2 comments
Open

Delay flow start until sufficient volume is observed #77

mik3y opened this issue Mar 31, 2014 · 2 comments

Comments

@mik3y
Copy link
Member

mik3y commented Mar 31, 2014

Folks are getting spurious flow activations due to minor disturbances / bubbles. IIRC there's already a heuristic but it may be broken.

@mik3y mik3y added this to the v1.0 milestone Apr 14, 2014
@jlopp
Copy link

jlopp commented May 22, 2014

Came here to report the same issue. I specifically have noted that sometimes when a user bumps into our kegerator, it sets off the sensor and the app believes that a pour has begun. What threshold of volume poured is required to set off a pour event? Seems like you should require at least several mL of flow before considering it a real event.

@mik3y
Copy link
Member Author

mik3y commented May 22, 2014

@jlopp: There is a setting in the app (Settings -> Kegerator -> Minimum Volume), but it's only applied at record time (ie the UI may still spin up and make a racket).

The code needs to be modified to consider a sliding window of activity. We also need to be careful that slow pours (or worse, leaks) don't evade observation, ie, rate is considered with a cutoff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants