Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Icons! #4073

Open
irasponsible opened this issue Apr 5, 2024 · 4 comments
Open

[Feature]: Icons! #4073

irasponsible opened this issue Apr 5, 2024 · 4 comments
Labels
Enhancement GUI Issues affecting the interactive GUI

Comments

@irasponsible
Copy link
Contributor

irasponsible commented Apr 5, 2024

G'day,

I made up some new icons for the CKAN Client, Console, and Command prompt. Is it worth baking these into .ico files at the right sizes for CKAN and making a pull request?

Suggestion

CLIENT CONSOLE CMD
kerbal-space-program-ckan kerbal-space-program-ckan-console kerbal-space-program-ckan-cmdprompt

Additional context

I used these SVGs of the KSP logo on the Official KSP website. If we had permission from SQUAD for the current iteration, they'd probably be alright with use of the updated logo? I'm happy to put in the legwork to contact Intercept/PD about it.

These icons are based on the Papirus open-source icon theme. This is 64px, I've also done the other size svgs.

I also did some others up, which I plan to submit to Papirus at some point. Might even do up a full rainbow for people with too many KSP installs!

KSP 1 KSP 2 KSP RSS
ksp@64x64 kspdark@64x64 ksprss@64x64
@HebaruSan HebaruSan added Enhancement Easy This is easy to fix GUI Issues affecting the interactive GUI and removed Easy This is easy to fix labels Apr 5, 2024
@HebaruSan
Copy link
Member

Hi, really neat work!

I have a couple of points of feedback to bring up:

  • The current/old icon says "CKAN", and these don't. I think that'd be an important way to differentiate it from the KSP1 and/or KSP2 icons. If these were on my taskbar, I don't think I'd be able to tell what to click to launch CKAN vs the games.
  • I'm skeptical about your hope that years-ago permission to use a particular icon applies to future icons. I'm also a bit nervous about asking, since the franchise has changed hands since then and we don't know whether the new owners would have the same attitude or even remember their predecessors' decisions. I wouldn't want an email forwarded to their (new) legal team to trigger a cease and desist letter and have to stop using even the old icon that we have now.
    • Then again, maybe a completely new, completely original icon would be best, since we've begun branching out into supporting multiple games. A KSP-related icon would seem out of place if we eventually add support for games outside that franchise.
  • How exactly are you imagining the CmdLine and ConsoleUI ones would be used? All three UIs live inside the same .exe file, which can only have one icon. We could probably set them up to show up in the system menus in Ubuntu/Fedora, since those are separate .desktop files that can reference whatever standalone icon files they want, but other than that I would not know where to put them.

@HebaruSan
Copy link
Member

Looking at that link for Papirus, could we make it possible for icon libraries like that to set their own icons for CKAN? I haven't looked at the spec for this recently, but I would guess that could be done by changing the Icon property in the .desktop file from a path to a generic symbol?

Icon=/usr/share/icons/ckan.ico

Icon=ckan

If that worked, then we might be able to offload some of the "risk" of a derivative icon to such projects. I.e., if Papirus gets a C&D letter, that wouldn't affect us.

@irasponsible
Copy link
Contributor Author

The current/old icon says "CKAN", and these don't. I think that'd be an important way to differentiate it from the KSP1 and/or KSP2 icons. If these were on my taskbar, I don't think I'd be able to tell what to click to launch CKAN vs the games.

I'll admit, this started out as me wanting a couple of different icons for different KSP1 instances. CKAN's default icon didn't show up very well at 24x24px so I was using a generic one.
In my head the white/red vs red/white was enough of a distinction, but I was the one who made them, so of course I thought so!

I'll try and come up with something more CKAN specific, maybe just the "rocket plume lens flare" shape and "CKAN", which would pay some homage to the original but still be generic for if CKAN expands. Also neatly nips licencing questions in the bud.

How exactly are you imagining the CmdLine and ConsoleUI ones would be used? All three UIs live inside the same .exe file, which can only have one icon. We could probably set them up to show up in the system menus in Ubuntu/Fedora, since those are separate .desktop files that can reference whatever standalone icon files they want, but other than that I would not know where to put them.

I'm using Debian 12 with KDE, where they already show up as three separate options - I assumed that was how it showed up on Windows! I think since CKAN comes with three .desktops, it'll show three menu entries. It was the same on Linux Mint.

Looking at that link for Papirus, could we make it possible for icon libraries like that to set their own icons for CKAN?

I'm happy to do the digging to see how to set it up properly! It's also possible for a user to just set them manually (KDE and Mint have menu editors, or can just edit the .desktop in a text editor.)

@irasponsible
Copy link
Contributor Author

irasponsible commented Apr 6, 2024

Here's what I could come up with.

Client Console Command
template-ckan-light-red@64x64 template-ckan-green-dark@64x64 template-ckan-purple-dark@64x64
Wide Wide (alt)
ckan-wide-white@128x64 ckan-wide-wide@128x64

Tried to keep the current 'motif' as much as I could. Font is "Nasalization" by Typodermic, which has a licence that allows this use.

edit: oops, the font didn't render properly. i'll fix it later - I forgot to turn the text into a path, so it shows up as generic Arial or something at the moment.

edit 2: hopefully that works properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement GUI Issues affecting the interactive GUI
Projects
None yet
Development

No branches or pull requests

2 participants