A good trade was ignored #3203
Comments
woctezuma
added
🐛 Bug
|
I will try again without custom plugins later, but I don't expect a change of behavior. |
JustArchi
added
💭 Acknowledged
|
No need, I've confirmed it with unit test on our side. I have no clue what's wrong yet, but it's enough to move the issue forward. |
JustArchi
added
✔️ Confirmed
|
Thank you a lot for reporting this issue, I've managed to add unit test verifying that what you stated above is correct, and ASF behaviour was wrong. When excessive amount of "missing amounts", so items in the set was missing on our side, there was a possibility for our logic to classify a good trade as bad one, because we didn't fill in enough holes, as the subtraction in the condition was calculated on each loop rather than once initially. Since this could only worsen the neutrality score, but never improve it (as the amounts were sorted ascending), there was no abusive possibility due to that, only ignoring otherwise valid trades classifying them as worse than they were in reality. Fixed in V6.0.3.1 which I'll release in a second. |
|
Thank you! Have a nice week! |
Checklist
ASF version
Latest stable release
ASF variant
generic (with latest .NET runtime)
Bug description
I have received this trade of 3 unmarketable cards in exchange of 3 of mine of the same set.
This trade would:
Expected behavior
The trade should have been accepted, because it is good.
Actual behavior
Steps to reproduce
No response
Possible reason/solution
No response
Can you help us with this bug report?
Somehow, I can test and offer feedback, but can't code
Full log.txt recorded during reproducing the problem
Global ASF.json config file
{ "MaxTradeHoldDuration": 0, "PluginsUpdateList": [ "FreePackages", "CommandlessRedeem", "BoosterManager", "ASFEnhance", "CaseInsensitiveASF" ], "SteamOwnerID": ***, "SteamTokenDumperPluginEnabled": false, "ASFEnhance": { "EULA": false, "Statistic": false, "AutoClaimItemBotNames": "ASF", "DisabledCmds": [ "ga" ] } }BotName.json config of all affected bot instances
{ "BotBehaviour": 40, "Enabled": true, "FarmingPreferences": 128, "HoursUntilCardDrops": 0, "OnlineStatus": 7, "PasswordFormat": 1, "RedeemingPreferences": 5, "RemoteCommunication": 2, "SteamLogin": "***", "SteamMasterClanID": ***, "SteamPassword": "***", "TradingPreferences": 3, "EnableFreePackages": true, "FreePackagesFilter": { "PlaytestMode": 3, "IgnoreFreeWeekends": true, "IgnoredTypes": [ "Demo" ] }, "GamesToBooster": [ 332070 ] }Additional info
No response
The text was updated successfully, but these errors were encountered: