Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPCReply.Ok nuances need documentation #55

Open
wtucker opened this issue Feb 19, 2018 · 2 comments
Open

RPCReply.Ok nuances need documentation #55

wtucker opened this issue Feb 19, 2018 · 2 comments
Labels
documentation help-wanted

Comments

@wtucker
Copy link
Contributor

wtucker commented Feb 19, 2018

Docstring should make it clear that Ok being true does not mean that Errors is empty.
@wtucker wtucker mentioned this issue Feb 19, 2018
Open
@nemith
Copy link
Collaborator

nemith commented Jul 22, 2022

According the the RFC yes. According to broken Junos code no.

@nemith
Copy link
Collaborator

nemith commented Jul 22, 2022

PR welcome

nemith added a commit that referenced this issue Mar 13, 2024
@nemith
fix CreateSubscription test (#55)
dd5a04d 
Since the xml namespace for `<create-subscription>` is different from
the base namespace it need to be explicit and it was missing from the
match side of the tests.

Also moved to `time.Date` from `time.Parse` to get rid of some unneeded
error handling and migrated the tests to use testify to make the output
more clear.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation help-wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nemith @wtucker