From fc5fb97dc222595fd8f9b3510fd5d48b479b223a Mon Sep 17 00:00:00 2001 From: Hampapur Ajay Date: Thu, 29 Jan 2015 12:20:52 -0800 Subject: [PATCH] config-autogen: generate sort operation outside for loop List operations in scale tests are inefficient due to incorrect position of sort call. Change-Id: Id695a55a48945806cd477a1520731f45fb691c56 Closes-Bug: #1416089 (cherry picked from commit 74b8b44e456f529a06c26a5a91b33444752a2bd6) --- ifmap_frontend.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ifmap_frontend.py b/ifmap_frontend.py index 231c213..c798394 100644 --- a/ifmap_frontend.py +++ b/ifmap_frontend.py @@ -3227,10 +3227,10 @@ def _generate_cassandra_db_impl(self, gen_fname, gen_type_pfx): write(gen_file, " unsorted_fq_names_uuids.append({'fq_name': child_fq_name, 'uuid': child_uuid,") write(gen_file, " 'tstamp': tstamp})") write(gen_file, "") - write(gen_file, " # sort children; TODO do this based on schema") - write(gen_file, " sorted_children = sorted(unsorted_fq_names_uuids, key = itemgetter('tstamp'))") - write(gen_file, " # re-write result's children without timestamp") - write(gen_file, " children_fq_names_uuids = [(child['fq_name'], child['uuid']) for child in sorted_children]") + write(gen_file, " # sort children; TODO do this based on schema") + write(gen_file, " sorted_children = sorted(unsorted_fq_names_uuids, key = itemgetter('tstamp'))") + write(gen_file, " # re-write result's children without timestamp") + write(gen_file, " children_fq_names_uuids = [(child['fq_name'], child['uuid']) for child in sorted_children]") write(gen_file, " if back_ref_uuids:") write(gen_file, " # go from anchor to backrefs") write(gen_file, " obj_uuid_cf = self._obj_uuid_cf")