From 8829dd0ad7d8b3c4e5a5f310e6402382b50188ba Mon Sep 17 00:00:00 2001
From: Nikhil B <nikhilb@juniper.net>
Date: Wed, 18 Nov 2015 13:46:58 +0530
Subject: [PATCH] Dont log error in case of eof error for async_read

async_read returns eof to indicate that the other side has closed the socket.
This is a way for other side to know that socket should be closed now. There
is no need to log since it is not an error condition

Closes-Bug: 1506795

Change-Id: I5dc5dc0cb9a909d97dacff8ceef89c863a7536c7
(cherry picked from commit ef96e3dd4710387d8aed63c948a8b74875900836)
---
 src/io/tcp_session.cc | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/io/tcp_session.cc b/src/io/tcp_session.cc
index e3f50558070..bfaec7b0e6c 100644
--- a/src/io/tcp_session.cc
+++ b/src/io/tcp_session.cc
@@ -428,9 +428,12 @@ void TcpSession::AsyncReadHandler(
 
     if (IsSocketErrorHard(error)) {
         session->ReleaseBufferLocked(buffer);
-        TCP_SESSION_LOG_ERROR(session, TCP_DIR_IN,
+	// eof is returned when the peer closed the socket, no need to log err
+	if (error != error::eof) {
+	    TCP_SESSION_LOG_ERROR(session, TCP_DIR_IN,
                               "Read failed due to error " << error.value()
                               << " : " << error.message());
+	}
         lock.release();
         session->CloseInternal(error, true);
         return;
@@ -441,9 +444,12 @@ void TcpSession::AsyncReadHandler(
         // check error code if session needs to be closed
         if (IsSocketErrorHard(err)) {
             session->ReleaseBufferLocked(buffer);
-            TCP_SESSION_LOG_ERROR(session, TCP_DIR_IN,
+	    // eof is returned when the peer has closed the socket
+	    if (error != error::eof) {
+		TCP_SESSION_LOG_ERROR(session, TCP_DIR_IN,
                                   "Read failed due to error " << err.value()
                                   << " : " << err.message());
+	    }
             lock.release();
             session->CloseInternal(err, true);
             return;