From 8af0a45d6f115bf600f870ad975b5b7d85fb4843 Mon Sep 17 00:00:00 2001 From: Anish Mehta Date: Wed, 29 Jun 2016 13:37:38 -0700 Subject: [PATCH] Fixing memory leak when kafka producer is not present. Closes-Bug:1586189 Change-Id: I3c5cec11145e2650ab6e40bfda8dd633ec7bfca8 --- src/analytics/OpServerProxy.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/analytics/OpServerProxy.cc b/src/analytics/OpServerProxy.cc index efa018e8eff..82231c6962b 100644 --- a/src/analytics/OpServerProxy.cc +++ b/src/analytics/OpServerProxy.cc @@ -124,16 +124,17 @@ class OpServerProxy::OpServerImpl { LOG(ERROR, "Kafka ignoring KafkaPub"); return; } - char* gn = new char[gen.length()+1]; - strcpy(gn,gen.c_str()); if (producer_) { + char* gn = new char[gen.length()+1]; + strcpy(gn,gen.c_str()); + // Key in Kafka Topic includes UVE Key, Type producer_->produce(topic_[pt].get(), 0, RdKafka::Producer::MSG_COPY, const_cast(value.c_str()), value.length(), &skey, (void *)gn); - } + } } struct RedisInfo {