Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert TermInterface integration #596

Merged
merged 5 commits into from
May 16, 2024
Merged

revert TermInterface integration #596

merged 5 commits into from
May 16, 2024

Conversation

shashi
Copy link
Member

@shashi shashi commented May 14, 2024 •
edited by bowenszhu

@shashi
Revert "Merge pull request #584 from JuliaSymbolics/ale/terminterface…
0b75a32 
…-new"

This reverts commit 6713fa0, reversing
changes made to 8d8db32.
@shashi
Copy link
Member Author

shashi commented May 14, 2024

Can revert this revert and release a major version.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited

Benchmark Results

master 6367804... master/6367804ce14f3b...
overhead/acrule/a+2 0.732 ± 0.024 μs 0.763 ± 0.024 μs 0.96
overhead/acrule/a+2+b 0.703 ± 0.021 μs 0.736 ± 0.022 μs 0.956
overhead/acrule/a+b 0.268 ± 0.01 μs 0.265 ± 0.011 μs 1.01
overhead/acrule/noop:Int 26.2 ± 0.91 ns 25.9 ± 0.92 ns 1.01
overhead/acrule/noop:Sym 0.0373 ± 0.0057 μs 0.0373 ± 0.0058 μs 1
overhead/rule/noop:Int 0.0444 ± 0.0012 μs 0.0457 ± 0.001 μs 0.97
overhead/rule/noop:Sym 0.056 ± 0.0028 μs 0.058 ± 0.0039 μs 0.967
overhead/rule/noop:Term 0.0561 ± 0.0028 μs 0.0574 ± 0.0036 μs 0.978
overhead/ruleset/noop:Int 0.13 ± 0.0027 μs 0.132 ± 0.0032 μs 0.986
overhead/ruleset/noop:Sym 0.154 ± 0.0066 μs 0.162 ± 0.0071 μs 0.946
overhead/ruleset/noop:Term 7.22 ± 0.48 μs 3.69 ± 0.21 μs 1.96
overhead/simplify/noop:Int 0.151 ± 0.0018 μs 0.143 ± 0.0042 μs 1.06
overhead/simplify/noop:Sym 0.159 ± 0.0052 μs 0.15 ± 0.0046 μs 1.07
overhead/simplify/noop:Term 0.0459 ± 0.0031 ms 0.0406 ± 0.0028 ms 1.13
overhead/simplify/randterm (+, *):serial 0.142 ± 0.0061 s 0.129 ± 0.0054 s 1.1
overhead/simplify/randterm (+, *):thread 0.0835 ± 0.027 s 0.0771 ± 0.023 s 1.08
overhead/simplify/randterm (/, *):serial 0.279 ± 0.015 ms 0.233 ± 0.011 ms 1.2
overhead/simplify/randterm (/, *):thread 0.32 ± 0.016 ms 0.268 ± 0.013 ms 1.19
overhead/substitute/a 0.126 ± 0.0046 ms 0.0612 ± 0.0022 ms 2.06
overhead/substitute/a,b 0.106 ± 0.0045 ms 0.0536 ± 0.0025 ms 1.97
overhead/substitute/a,b,c 17.1 ± 0.87 μs 17.6 ± 0.9 μs 0.972
polyform/easy_iszero 0.0586 ± 0.0043 ms 0.0333 ± 0.0024 ms 1.76
polyform/isone 2.79 ± 0.01 ns 2.79 ± 0.01 ns 1
polyform/iszero 2.53 ± 0.064 ms 1.82 ± 0.037 ms 1.39
polyform/simplify_fractions 2.84 ± 0.065 ms 2.48 ± 0.053 ms 1.14
time_to_load 4.72 ± 0.036 s 4.8 ± 0.071 s 0.983

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@shashi shashi changed the title remove TermInterface related depwarns revert TermInterface integration May 16, 2024
@shashi shashi merged commit 38ec2bb into master May 16, 2024
9 of 12 checks passed
@shashi shashi deleted the s/remove-TI-depwarns branch May 16, 2024 14:47
@shashi shashi restored the s/remove-TI-depwarns branch May 17, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning about istree deprecation SymbolicUtils 1.6.0 breaks MTK v8
1 participant
@shashi