Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process_raw! fails on NodalData #104

Open
stepholinger opened this issue Feb 1, 2023 · 2 comments
Open

process_raw! fails on NodalData #104

stepholinger opened this issue Feb 1, 2023 · 2 comments

Comments

@stepholinger
Copy link
Contributor

stepholinger commented Feb 1, 2023

When the process_raw! function is applied to NodalData, the following error is produced:

MethodError: no method matching process_raw!(::SeisIO.Nodal.NodalData, ::Float64)
Closest candidates are:
  process_raw!(::SeisData, ::Real; ϕshift) at ~/.julia/packages/SeisNoise/E7Pc3/src/compute_fft.jl:20
  process_raw!(::SeisChannel, ::Real; ϕshift) at ~/.julia/packages/SeisNoise/E7Pc3/src/compute_fft.jl:51

Stacktrace:
 [1] top-level scope
   @ In[10]:1

Applying detrend!, taper! and bandpass! to NodalData works fine, so it may be a simple matter of adding NodalData as an acceptable input type for process_raw!, or defining a new function to specifically handle the NodalData.

@stepholinger stepholinger changed the title process_raw! for NodalData process_raw! fails on NodalData Feb 2, 2023
@tclements
Copy link
Collaborator

Thanks for finding this! I'm leaning towards deprecating process_raw in favor of applying individual processing functions (detrend, taper, bandpass). I think that leads to more understandable code. I need to update the docs to reflect that...

@stepholinger
Copy link
Contributor Author

I agree, that would make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants