Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heatmap handling of NaN #362

Open
fredcallaway opened this issue Oct 28, 2023 · 4 comments
Open

Heatmap handling of NaN #362

fredcallaway opened this issue Oct 28, 2023 · 4 comments

Comments

@fredcallaway
Copy link

It seems that the current behavior of heatmap is to replace NaN values with a grid of transparent and white cells:

image

I think it would make much more sense if NaN mapped to a consistent color, probably transparent.

@t-bltg
Copy link
Member

t-bltg commented Nov 7, 2023

Actually, a row consist of half blocks characters at the bottom, with a background color for the remaining upper part.

@fredcallaway
Copy link
Author

Hmm, well then half blocks must be used throughout because the NaN cells are the same size as the other ones (you can see that you get one row for each of the 8 rows in the matrix above).

Implementation aside, the question is: should NaN be represented by a single color everywhere or a different color depending on what row you're in?

@sadish-d
Copy link

The only thing that makes sense to me is for NaNs to be transparent. This makes sense because they can, in practice, be used to represent missing values.

@t-bltg
Copy link
Member

t-bltg commented Apr 19, 2024

I agree that we should probably switch to no coloring for NaNs, to be consistent with other plotting libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants