Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too long stack traces at the REPL shell mode #54277

Open
LilithHafner opened this issue Apr 26, 2024 · 2 comments
Open

Too long stack traces at the REPL shell mode #54277

LilithHafner opened this issue Apr 26, 2024 · 2 comments
Labels
domain:error messages Better, more actionable error messages

Comments

@LilithHafner
Copy link
Member

I recently typed ;git push' and got the following result:

Screenshot from 2024-04-26 15-26-28

Once I scrolled up, I saw this:

shell> git push'
ERROR: unterminated single quote
Stacktrace:
  [1] error(s::String)
    @ Base ./error.jl:35
  [2] shell_parse(str::String, interpolate::Bool; special::String, filename::String)
    @ Base ./shell.jl:139
  [3] shell_parse (repeats 2 times)
    @ ./shell.jl:31 [inlined]
  [4] (::REPL.var"#104#116"{REPL.LineEditREPL})(line::Any)
    @ REPL ~/.julia/juliaup/julia-1.11.0-beta1+0.aarch64.linux.gnu/share/julia/stdlib/v1.11/REPL/src/REPL.jl:1113
  [5] #invokelatest#2
    @ ./essentials.jl:1030 [inlined]
  [6] invokelatest
    @ ./essentials.jl:1027 [inlined]
  [7] (::REPL.var"#do_respond#93"{})(s::REPL.LineEdit.MIState, buf::Any, ok::Bool)
    @ REPL ~/.julia/juliaup/julia-1.11.0-beta1+0.aarch64.linux.gnu/share/julia/stdlib/v1.11/REPL/src/REPL.jl:976
  [8] #invokelatest#2
    @ ./essentials.jl:1030 [inlined]
  [9] invokelatest
    @ ./essentials.jl:1027 [inlined]
 [10] run_interface(terminal::REPL.Terminals.TextTerminal, m::REPL.LineEdit.ModalInterface, s::REPL.LineEdit.MIState)
    @ REPL.LineEdit ~/.julia/juliaup/julia-1.11.0-beta1+0.aarch64.linux.gnu/share/julia/stdlib/v1.11/REPL/src/LineEdit.jl:2748
 [11] run_frontend(repl::REPL.LineEditREPL, backend::REPL.REPLBackendRef)
    @ REPL ~/.julia/juliaup/julia-1.11.0-beta1+0.aarch64.linux.gnu/share/julia/stdlib/v1.11/REPL/src/REPL.jl:1407
 [12] (::REPL.var"#75#81"{REPL.LineEditREPL, REPL.REPLBackendRef})()
    @ REPL ~/.julia/juliaup/julia-1.11.0-beta1+0.aarch64.linux.gnu/share/julia/stdlib/v1.11/REPL/src/REPL.jl:457
Some type information was truncated. Use `show(err)` to see complete types.

That's a huge amount of noise. The bottom 8 stack frames (at least) should be removed IMO.

@LilithHafner LilithHafner added the domain:error messages Better, more actionable error messages label Apr 26, 2024
@IanButterworth
Copy link
Sponsor Member

I think a stack trace is just not needed here (or ever in shell mode?)

@KristofferC
Copy link
Sponsor Member

KristofferC commented May 2, 2024

The stacktrace from running the command and having it fail has been removed, but not the one that comes when the shell_parse itself errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:error messages Better, more actionable error messages
Projects
None yet
Development

No branches or pull requests

3 participants