Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Face for end keyword #170

Open
kauesena opened this issue Apr 10, 2022 · 8 comments
Open

Face for end keyword #170

kauesena opened this issue Apr 10, 2022 · 8 comments

Comments

@kauesena
Copy link

kauesena commented Apr 10, 2022

It would be nice to have a special face of the end keyword. One may wish to give it a discreet colour so that the end's become more inconspicuous.

@tpapp
Copy link
Collaborator

tpapp commented Apr 11, 2022

Technically it is feasible, but I guess most people prefer to have it match the openings begin, for, while, function, struct, etc.

@kauesena
Copy link
Author

I believe you are right. I think the majority would keep them with matching colors.

But possibly users coming from Python and whose theme uses a showy color for keywords would like to partially hide the ends. If one uses visual guides for indentation, such as those provided by the minor mode highlight indent guides, one may colour the end keywords as the guides.
Or even one could go unorthodox, keep a sequence of end's in one line in a lisp fashion. I do think, however, a begin without a clearly matching end may be a bit weird, "begins and never ends".

@tpapp
Copy link
Collaborator

tpapp commented Apr 12, 2022

Similarly to my comment in the other issue, I have no objections to this in principle (we can always inherit a default from another face so existing setups are unaffected), but I would suggest waiting a bit for comments.

@kauesena
Copy link
Author

Regarding this issue, besides asking about the possibility of implementing such a face now that some time has elapsed, I'd just like to add this fact I came across: atom already dims the end's by default and the vscode Julia extension defines a face specifically for the end keyword. I mention that to imply it does not seem to be odd to have such a face for Julia, even though I'd guess most Emacs users would still prefer the end keyword to be as clearly visible as the opening keywords such as begin and while.

@tpapp
Copy link
Collaborator

tpapp commented Jul 11, 2022

A PR is welcome, but please default to current behavior.

@kauesena
Copy link
Author

I'll make sure the current behaviour is the default one!

@kauesena
Copy link
Author

I saw using to tree-sitter is being considered. That would refine font-locking, right? Should I hold back?

@tpapp
Copy link
Collaborator

tpapp commented Jul 15, 2022

Possibly, but we have no timeframe on #174.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants