Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance drop; need symbol table #18

Open
JoshDreamland opened this issue Jul 3, 2020 · 0 comments
Open

Performance drop; need symbol table #18

JoshDreamland opened this issue Jul 3, 2020 · 0 comments

Comments

@JoshDreamland
Copy link
Owner

Performance is looking pretty terrible. The more academic approach to lexing is partially responsible, but the core issue is that COW strings are gone. We're now SSO, which means we're copying variable names and chunks of code everywhere. Things that used to be efficient by-value are now terrible. So, thanks, Google.

JDI needs to incorporate a proper symbol table to deal with that. We can just store everything in it, honestly; doc comments, too, as needed.

Some of the macro application logic is particularly egregious as it hybridizes the string copy performance hit with dropping the optimizations that made the code difficult to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant