Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database session support for all new types of output #224

Open
Jammy2211 opened this issue Aug 12, 2023 · 0 comments
Open

Database session support for all new types of output #224

Jammy2211 opened this issue Aug 12, 2023 · 0 comments
Assignees

Comments

@Jammy2211
Copy link
Owner

The following test script tries to perform a normal lens model fit where results are written to the database as a session:

https://github.com/Jammy2211/autolens_workspace_test/blob/main/database/session/slam_simple.py

For example it currently gives the following exception:

Traceback (most recent call last):
  File "/mnt/c/Users/Jammy/Code/PyAuto/autolens_workspace_test/database/session/slam_simple.py", line 145, in <module>
    source_lp_results = slam.source_lp.run(
  File "/mnt/c/Users/Jammy/Code/PyAuto/autolens_workspace_test/slam/source_lp.py", line 108, in run
    result_1 = search_1.fit(
  File "/mnt/c/Users/Jammy/Code/PyAuto/PyAutoFit/autofit/non_linear/search/abstract_search.py", line 490, in fit
    analysis = analysis.modify_before_fit(paths=self.paths, model=model)
  File "/mnt/c/Users/Jammy/Code/PyAuto/PyAutoLens/autolens/imaging/model/analysis.py", line 49, in modify_before_fit
    super().modify_before_fit(paths=paths, model=model)
  File "/mnt/c/Users/Jammy/Code/PyAuto/PyAutoLens/autolens/analysis/analysis.py", line 255, in modify_before_fit
    super().modify_before_fit(paths=paths, model=model)
  File "/mnt/c/Users/Jammy/Code/PyAuto/PyAutoGalaxy/autogalaxy/analysis/analysis.py", line 268, in modify_before_fit
    self.check_and_replace_adapt_images(paths=paths)
  File "/mnt/c/Users/Jammy/Code/PyAuto/PyAutoGalaxy/autogalaxy/analysis/analysis.py", line 505, in check_and_replace_adapt_images
    adapt_model_image = load_adapt_image(filename="adapt_model_image.fits")
  File "/mnt/c/Users/Jammy/Code/PyAuto/PyAutoGalaxy/autogalaxy/analysis/analysis.py", line 499, in load_adapt_image
    file_path=paths._files_path / "adapt" / filename,
  File "/mnt/c/Users/Jammy/Code/PyAuto/PyAutoFit/autofit/non_linear/paths/abstract.py", line 240, in _files_path
    raise NotImplementedError
NotImplementedError

This occurs because it tries to load the image paths._files_path / "adapt" / filename via a DirectoryPaths when it should be via the database.

Can you run this script and fix issues that come up until using a session works end-to-end (like using directories).

I think most issues will be things like .fits file not being supported to be loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants