Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entities are not counted correctly on merged plots #4269

Closed
2 tasks done
Tamikaschu opened this issue Dec 20, 2023 · 6 comments · May be fixed by #4357
Closed
2 tasks done

Entities are not counted correctly on merged plots #4269

Tamikaschu opened this issue Dec 20, 2023 · 6 comments · May be fixed by #4357
Labels
Approved A project maintainer or developer has reproduced this issue Bug Something isn't working Good first issue Simple issue which would be a good first PR for newbies interested in contributing to the project

Comments

@Tamikaschu
Copy link
Contributor

Server Implementation

Paper

Server Version

1.20

Describe the bug

Entities will not get counted correctly on merged plots resulting in never reaching the plot cap limit and overflowing the plot.

To Reproduce

  1. Merge a few plots
  2. Set a Spawner (e.g Villager Spawner)
  3. Check if the entities are being counted correctly (/p caps)

Expected behaviour

Entities should be counted correctly

Screenshots / Videos

Merged plot:
image
image

Single plot:
image
image

Error log (if applicable)

No response

Plot Debugpaste

https://athion.net/ISPaster/paste/view/1dc97f594f544d79ae8f6d9e68a8f485

PlotSquared Version

PlotSquared version 7.2.1-Premium

Checklist

Anything else?

No response

@Tamikaschu Tamikaschu added the Requires Testing This is a new issue which needs to be approved before labeled with "bug" label Dec 20, 2023
@Tamikaschu
Copy link
Contributor Author

Quite similar to #3050 the problem is not resolved for me though

@ch4ika
Copy link
Contributor

ch4ika commented Dec 23, 2023

I have the same problem, my players have over 1000 entities even though the cap is 75 for me.
paper 1.20.2

@OneLiteFeather
Copy link
Member

Villagers don't really count as mobs or animals in plotsquared. You could implement a third party flag for villagers for your own or suggest the flag as a feature. I've seen this happening with villagers for like 3 years on different servers.

@OneLiteFeather OneLiteFeather added Bug Something isn't working Approved A project maintainer or developer has reproduced this issue Good first issue Simple issue which would be a good first PR for newbies interested in contributing to the project and removed Requires Testing This is a new issue which needs to be approved before labeled with "bug" labels Dec 23, 2023
@Tamikaschu
Copy link
Contributor Author

Tamikaschu commented Jan 7, 2024

Actually the villagers are counted as cap type mobs and animals. On a single plot they will get counted correctly and therefore reach the cap and stop spawning from there on. On a merged plot though this is not the case. They will surpass the mobs cap on a merged plot.

@ch4ika
Copy link
Contributor

ch4ika commented Jan 29, 2024

The problem here is that the caps constantly reset as soon as an entity crosses a merged plot.
The entity count meta is reset every time during the transition, and this then calculates that the plot has no mobs and therefore the calculation is done again from the beginning every time.

@Tamikaschu
Copy link
Contributor Author

Problem is caused by the same issue as it was described in #4338. Though i don't know why this one was accepted and the other marked as invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved A project maintainer or developer has reproduced this issue Bug Something isn't working Good first issue Simple issue which would be a good first PR for newbies interested in contributing to the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants