Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage and add object mockers #180

Open
jacopoabramo opened this issue Jun 23, 2023 · 0 comments
Open

Improve test coverage and add object mockers #180

jacopoabramo opened this issue Jun 23, 2023 · 0 comments

Comments

@jacopoabramo
Copy link
Collaborator

jacopoabramo commented Jun 23, 2023

As correctly pointed out by @kasasxav in #166, we need to improve code coverage and add object mockers.

What I'm thinking for mockers though is that your testing with the Hamamatsu mock forces developers to integrate a mock object for each device manager that they implement (i.e. here) . It doesn't seem ideal to me. I would instead consider the possibility to load the mockers withing each specific DevicesManager (DetectorsManager, PositionersManager, etc.) so that when an exception is thrown the mock is loaded for that device.

It moves the implementation to the higher stack and relieves the stress of developers to implement their own everytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant