Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in doTask(Conj, ScalarCplx &d)? #282

Open
kyungminlee opened this issue Nov 6, 2019 · 2 comments · May be fixed by #283
Open

bug in doTask(Conj, ScalarCplx &d)? #282

kyungminlee opened this issue Nov 6, 2019 · 2 comments · May be fixed by #283
Labels
Bug

Comments

@kyungminlee
Copy link
Contributor

ITensor/itensor/itdata/scalar.h

Line 178 in 78eb39a

doTask(Conj, ScalarCplx & d) { std::conj(d.val); }

Should this line be something like the following?

void inline doTask(Conj, ScalarCplx & d) { d.val = std::conj(d.val); }
@kyungminlee kyungminlee changed the title doTaskl(Conj, ScalarCplx &d) bug in doTask(Conj, ScalarCplx &d)? Nov 6, 2019
@emstoudenmire
Copy link
Contributor

That looks about right - thanks for adding this. It would be a good idea to test it of course. Does std::conj do an in place operation or does it return the conjugated value? If the second one, then you’ll need to write: d.val = std::conj(d.val);

@emstoudenmire
Copy link
Contributor

Oh I didn’t see that was exactly the change you were suggesting. Yes we should make this change - if you could make a pull request it would be much appreciated.

@kyungminlee kyungminlee linked a pull request Nov 6, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug in doTask(Conj, ScalarCplx & d) kyungminlee/ITensor
2 participants
@kyungminlee @emstoudenmire