New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid globally namespaced Variables #1637

Open

drwells opened this issue Aug 17, 2023 · 0 comments

Member

drwells commented Aug 17, 2023

We're renaming some of these classes right now in the multiphase patches so we shouldn't fix this until that's done.

We presently have at least one Variable created as

 1167     HierarchyDataOpsManager<NDIM>* hier_ops_manager = HierarchyDataOpsManager<NDIM>::getManager();
 1168     d_hier_sc_data_ops =
 1169         hier_ops_manager->getOperationsDouble(new SideVariable<NDIM, double>("sc_var"), d_hierarchy,
                      true);

which isn't right - we don't want to globally namespace these things. In this particular case we should use d_V_var.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment