Replies: 8 comments 19 replies
-
|
@amneetb if you have more questions let me know - it would be good to collect all of this information in one place. |
Beta Was this translation helpful? Give feedback.
-
SET(CMAKE_REQUIRED_INCLUDES ${SAMRAI_INCLUDE_DIRS})
CHECK_CXX_SOURCE_COMPILES(
"
#include <SAMRAI_config.h>
#ifndef HAVE_MPI
#error
#endif
int main() {}
"
SAMRAI_WITH_MPI)
SET(CMAKE_REQUIRED_INCLUDES "")
IF(NOT ${SAMRAI_WITH_MPI})
MESSAGE(FATAL_ERROR "IBAMR requires that SAMRAI is built with MPI support.")
ENDIF()Unlike some newer build systems (e.g, meson) we still have a real programming language available to us for writing such checks.
|
Beta Was this translation helpful? Give feedback.
-
|
Thanks! |
Beta Was this translation helpful? Give feedback.
-
Getting error with CMake on OS X |
Beta Was this translation helpful? Give feedback.
-
|
FYI |
Beta Was this translation helpful? Give feedback.
-
|
Can you upload |
Beta Was this translation helpful? Give feedback.
-
|
@drwells : Attached |
Beta Was this translation helpful? Give feedback.
-
|
@drwells: It is also not able to find |
Beta Was this translation helpful? Give feedback.
-
|
It is surprising to see how brittle CMake is on some of the essential things like |
Beta Was this translation helpful? Give feedback.
-
|
I'm not convinced that this is a CMake problem. Check out this compiler line: This fails because there is no framework named |
Beta Was this translation helpful? Give feedback.
-
|
If it helps |
Beta Was this translation helpful? Give feedback.
-
|
@drwells: Did you get a chance to look into CMake problems on MacOS? |
Beta Was this translation helpful? Give feedback.
-
|
Not yet - I need to actually recompile mpich and everything else in order to reproduce this. There's one more quick thing we should check: can you paste the output of |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
Thanks. It's interesting that |
Beta Was this translation helpful? Give feedback.
-
|
Yup, its a bug with how CMake parses things: https://gitlab.kitware.com/cmake/cmake/-/issues/21741 I'll see if I can figure out a workaround. |
Beta Was this translation helpful? Give feedback.
-
|
One workaround is to use the MPI compiler wrappers. That works on my machine while just setting |
Beta Was this translation helpful? Give feedback.
-
|
I can try that. Can you send me the exact command line you used? |
Beta Was this translation helpful? Give feedback.
-
|
sure. I installed hypre and hdf5 through petsc, so they are all in the same place: #!/bin/bash
set -e
petsc=$HOME/Applications/petsc-3.13.1-mpich/x86_64-opt
MPI_ROOT=$HOME/Applications/mpich-4.0.2
cmake \
-DCMAKE_CXX_COMPILER=$MPI_ROOT/bin/mpic++ \
-DCMAKE_C_COMPILER=$MPI_ROOT/bin/mpicc \
-DCMAKE_Fortran_COMPILER=$MPI_ROOT/bin/mpifort \
-DPETSC_ROOT=$petsc \
-DHDF5_ROOT=$petsc \
-DHYPRE_ROOT=$petsc \
-DSAMRAI_ROOT=$HOME/Applications/SAMRAI-2.4.4-mpich \
..
make -j8I don't yet understand why this works but just providing MPI_ROOT does not. Regardless its a bug in cmake. |
Beta Was this translation helpful? Give feedback.
-
|
All the more reasons to support autotools as well. FWIW, Rahul was able to build IBAMR on Fugaku and K-computer in Japan using autotools (which speaks to its strength). |
Beta Was this translation helpful? Give feedback.
-
|
Indeed - we have put a lot of work into the autotools build system and it does what we need it to do. It would be interesting to hear about an experience of someone cross-compiling IBAMR with CMake too, though :) |
Beta Was this translation helpful? Give feedback.
-
|
Ok, the CMake works on IBAMR with the specified compilers. I was trying to define a |
Beta Was this translation helpful? Give feedback.
-
|
Unfortunately that's the same issue manifested in a different way - Some possible fixes:
|
Beta Was this translation helpful? Give feedback.
-
|
I think you also could add the C++ version flag to the name of the C++ compiler --- something like: |
Beta Was this translation helpful? Give feedback.
-
|
I added the same compiler options (without std C++11) to my project CMake configure. This made it work. |
Beta Was this translation helpful? Give feedback.
-
IBAMR presently supports configuration and compilation with two different build systems: autotools and CMake. In brief, the CMake-based build system will ultimately replace the autotools-based one due to its better feature set and lower overall maintenance cost. This discussion thread summarizes some FAQ and provides a place for people to discuss the new CMake build system.
PETSc uses BuildSystem and not CMake - why don't we use BuildSystem?
Why CMake instead of autotools?
In general, comparing these two build systems is somewhat difficult since autotools significantly predates CMake and served as the inspiration for much of CMake's design. The problems autotools set out to solve defined the initial scope and methods for CMake.
autoreconfand no longer have to deal with huge amounts of code changes resulting from increasing the version number of automake.libtoolfor relocating them.CMakeLists.txtfiles), the build system consists ofCMakeLists.txt,ibtk/src/CMakeLists.txt,src/CMakeLists.txt,tests/CMakeLists.txt, andcmake/IBAMRConfig.cmake.in: that's a total of five files for configuring the library, configuring the test suite, managing all dependencies, and installing information about our dependencies.Why autotools instead of CMake?
While moving to CMake is the right choice for us there are still many things which autotools does better:
configurescript will run on essentially any Unix machine from the last 25 years. While we are not that portable due to our C++11 requirement, a major advantage of autotools is that the build system itself will work with any Unix machine.CMakeor any other tool: everything is included in theconfigurescript../configure --help: we instead rely on information in the manual which may be out of date or difficult to locate for new users.FindPackage()functions can be brittle or break in weird ways. As a result our detection logic for MPI is much more complex for CMake than autotools.How long will IBAMR support both CMake and autotools?
Beta Was this translation helpful? Give feedback.
All reactions