Feature: as un admin, edit step of a request workflow.

[Sispheor]

After completing a step 2 on a request, one of the fielf was wrong. In the logs:

ERROR 2024-04-26 17:13:40,098 job Error launching job openshift-project-create, response was :{"variables_needed_to_start":["Value None for 'rwx_storage' expected to be an integer."]}

Durring the "admin" review we missed that this field was wrong and approve the request which is placed in failed state direcly

The edit button on top right corner only give access to the "user survey" or the "admin survey". But approval steps survey are not shown and so cannot be edited.

[Sispheor]

In this code we have this order when getting the form:

1. First Form (end user provided)
2. Admin form
3. Approval Step form

It means that the admin does't have the last word before processing a request.
But we have anyway the "accept" buton that allow to update the final form. But it's not taken in account because of the order.

From what I see we have two solution

• Remove the "review button" form the last admin step (and so as an admin if we always want to have the last work we need to always add a last step to each workflow)
• Keep the button and change the order of applied field update to have first form --> approval step form --> admin form

[Sispheor]

Done and available starting version 2.6.0