Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments difficult to read in pipeline rule "source code editor" when dark mode is used (6.x) #19346

Open
coffee-squirrel opened this issue May 14, 2024 · 0 comments

Comments

@coffee-squirrel
Copy link

coffee-squirrel commented May 14, 2024

Expected Behavior

All text should be easily readable when in dark mode.

For example, under 5.2.7:
image

Current Behavior

Comments in the pipeline rule "source code editor" are difficult to read when dark mode is used.

Under 6.0.1 (with the same text):
image

Steps to Reproduce (for bugs)

  1. Be on at least 6.0.0 and use dark mode
  2. Open the pipeline rule source code editor and add a rule with some comments
  3. Note it's somewhat difficult to read the comment text (slightly better when the row is selected)

Context

Not being able to clearly read all text makes working with pipeline rules more difficult under 6.0.x.

Somewhat related: the table header background color is also not great in dark mode under 6.0.x (message tables, Users list, Event Definitions list, etc.). It'd be nice if there was more contrast.

image

image

Your Environment

  • Graylog Version: 6.0.1
  • Browser version: Firefox 125, Chrome 124
@coffee-squirrel coffee-squirrel changed the title Comments difficult to read in pipeline rule "source code editor" when dark mode is used Comments difficult to read in pipeline rule "source code editor" when dark mode is used (6.x) May 15, 2024
@mako42 mako42 added the triaged label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants