Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow opentelemetry transform processor config to be passed from ops-agent config to the generated opentelemetry collector config #1686

Open
ryanohnemus opened this issue Apr 25, 2024 · 1 comment
Labels
customer-case-attached Issues that have a customer case number attached to them for Googlers to investigate feature New feature or request

Comments

@ryanohnemus
Copy link

Describe the feature
Currently only exclude_metric transforms are supported via the current documentation. There is no way to have opentelemetry transform processor config as part of the ops-agent config file (/etc/google-cloud-ops-agent/config.yaml) and have that configuration passed to the generated opentelemetry config that is used by the google-cloud-ops-agent-opentelemetry-collector service. The transform processor is supported by the google-cloud-ops-agent-opentelemetry-collector as you can edit the generated /run/google-cloud-ops-agent-opentelemetry-collector/otel.yaml, add a transform processor and restart the google-cloud-ops-agent-opentelemetry-collector and the metric transforms will work. There is also testdata in this repo that uses the metric transform processor (https://github.com/GoogleCloudPlatform/ops-agent/blob/master/confgenerator/testdata/goldens/combined-receiver_otlp/golden/linux/otel.yaml#L469), so i'm hoping this is just a small change to allow the ops-agent config to be passed to the generated opentelemetry-collector config.

Adding this feature should be enough to also close out #1682 as that issue seems to also be looking for a metric transform via:

metric_statements:
  - context: metric
statements:
  - extract_count_metrics(true) where name == "workload.googleapis.com/http.server.request.duration"
  - set(name, "workload.googleapis.com/http.server.request.count") where name == "workload.googleapis.com/http.server.request.duration_count"
  - set(unit, "1") where name == "workload.googleapis.com/http.server.request.count"
  - set(description, "Count of HTTP server requests.") where name == "workload.googleapis.com/http.server.request.count"
@sophieyfang
Copy link
Contributor

If you are able to, would you mind creating a cloud support ticket with us?

@igorpeshansky igorpeshansky added feature New feature or request customer-case-attached Issues that have a customer case number attached to them for Googlers to investigate labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-case-attached Issues that have a customer case number attached to them for Googlers to investigate feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants