Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support referencing/overriding the traceSampled field #1558

Open
rpysz opened this issue Jan 3, 2024 · 2 comments
Open

Support referencing/overriding the traceSampled field #1558

rpysz opened this issue Jan 3, 2024 · 2 comments

Comments

@rpysz
Copy link

rpysz commented Jan 3, 2024

Describe the bug
Issue similar to #1483. I would like to have a possibility to propagate "traceSampled" same way as "trace" and "spanId" (or rather have a possibility to always set this field to boolean true, not string "true" - Google API ignores stringified values of "traceSampled" field).

Expected behavior
'traceSampled' field properly propagated to Google Cloud Logging as boolean type

Environment:
VM distro / OS: Red Hat Enterprise Linux 8 (version 8.8)
Ops Agent version: 2.44.0

@jefferbrecht
Copy link
Member

As an alternative, would it be acceptable if the Ops Agent were to set traceSampled=true automatically whenever exporting a log that has trace or spanId? Or is there some other use case where you would need to be able to manually toggle traceSampled independently?

@rpysz
Copy link
Author

rpysz commented Jan 26, 2024

@jefferbrecht For my solution, always setting traceSampled=true is sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants