Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Prospective Search - refactor how servlet state is used for confirming tests. #61

Open
terryok opened this issue Oct 7, 2013 · 4 comments
Assignees

Comments

@terryok
Copy link
Contributor

terryok commented Oct 7, 2013

Same issue as before, a different instance of a servlet may get called, so we should use memcache or datastore to store test result info. MatchTests are failing with error, Servlet Not Invoked.

@ghost ghost assigned terryok Oct 7, 2013
@alesj
Copy link
Contributor

alesj commented Oct 8, 2013

I guess you didn't yet add a generic way to store temp info?
But np, I'll do it as soon as I find some time.

@terryok
Copy link
Contributor Author

terryok commented Oct 8, 2013

I'm thinking a simple key/value pair in memcache. The key would usually be something like "testname-timestamp". I like it better than using datastore since you don't need to worry about cleaning up.

@alesj
Copy link
Contributor

alesj commented Oct 8, 2013

How is it with duration of items in the cache?
I thought cache items can go out unexpectedly?

@terryok
Copy link
Contributor Author

terryok commented Oct 8, 2013

They can, but since the test itself is usually only 60 sec it would be a rare problem.

Although, now that you mention it, I wonder if there could be consistency issues. With datastore we can specify ancestor queries for consistency.

If the framework cleans up after itself, and every test has a unique key, so tests don't see old data that didn't get cleaned up for some reason, I think that would make the tests stable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants