Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Philips Hue polling in color temperature only mode #2081

Merged
merged 4 commits into from
May 20, 2024
Merged

Fix Philips Hue polling in color temperature only mode #2081

merged 4 commits into from
May 20, 2024
+145 −5

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented May 17, 2024 •
edited

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Description of change

Fix #2080

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented May 17, 2024 •
edited

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 08f67be
Status: ✅  Deploy successful!
Preview URL: https://104fcfbd.gladys-plus.pages.dev
Branch Preview URL: https://fix-philips-hue-poll-ct.gladys-plus.pages.dev

View logs

@relativeci RelativeCI
Copy link

relativeci bot commented May 17, 2024 •
edited

#2561 Bundle Size — 10.13MiB (~+0.01%).

08f67be(current) vs 70feeaa master#2560(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2561		      Baseline
#2560
Regression  Initial JS 5.45MiB(+0.01%) 5.45MiB
No change  Initial CSS 302.96KiB 302.96KiB
Change  Cache Invalidation 53.68% 0%
No change  Chunks 51 51
No change  Assets 170 170
No change  Modules 1479 1479
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2561		      Baseline
#2560
Regression  JS 7.23MiB (~+0.01%) 7.23MiB
No change  IMG 2.46MiB 2.46MiB
No change  CSS 319.75KiB 319.75KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.53KiB 17.53KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis report Branch fix-philips-hue-poll-ct Project dashboard

@codecov Codecov
Copy link

codecov bot commented May 17, 2024 •
edited

Codecov Report

Attention: Patch coverage is 86.84211% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 98.37%. Comparing base (7838bd6) to head (002a459).

❗ Current head 002a459 differs from pull request most recent head 08f67be

Please upload reports for the commit 08f67be to get more accurate results.

Files Patch % Lines
server/utils/colors.js 83.87% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2081      +/-   ##
==========================================
- Coverage   98.40%   98.37%   -0.04%     
==========================================
  Files         858      858              
  Lines       14038    14075      +37     
==========================================
+ Hits        13814    13846      +32     
- Misses        224      229       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pierre-Gilles Pierre-Gilles merged commit 1a4c6d1 into master May 20, 2024
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the fix-philips-hue-poll-ct branch May 20, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Philips Hue : Polling bug when the light has no x,y
1 participant
@Pierre-Gilles