-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FirebaseAuth exceptions are too generic #442
Comments
It should throw the same exception, can you supply some more details on how to reproduce this? |
@nbransby Hello, thanks for getting back to me! Anyways, I created this small app that showcases the problem I'm talking about: Let me know if there's anything else you need from me. |
@vladmircan I looked at your sample but it just looks like you are just choosing to catch the generic exception by using the FirebaseException base class instead of one of the subclasses such as FirebaseAuthInvalidCredentialsException? |
@nbransby That is true, I am catching the error as generic because otherwise the app just crashes (the thrown error is the generic The app basically just throws a However, while re-testing my repo, I noticed something: |
No its not expected behavior - I think it would help if you share the full stack trace of the original FirebaseException |
I have very similar issue. On android specific exception is thrown (like I think the bug is in the following piece of code from file I am on version
|
First of all, a huge thank you for the work you're doing here!
Now onto my issue:
I am in the process of migrating my app to
Kotlin Multiplatform
and I noticed some discrepancies in the wayFirebase
exceptions are thrown.Whereas the native SDK throws specific errors such as
FirebaseAuthInvalidCredentialsException
thegitlive
variant throws a genericFirebaseException
(with a descriptive message to be fair) thus making the error handling more difficult.N.B. I am in the early stages of my transition so I don't know if the same applies to other Firebase libraries as well.
Please let me know if this is an inherent limitation or if steps could be taken to improve this. Thanks!
The text was updated successfully, but these errors were encountered: