Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset ComplexDataFacade returning wrong empty value #4179

Open
stefan-korn opened this issue May 6, 2024 · 0 comments · May be fixed by #4180
Open

Dataset ComplexDataFacade returning wrong empty value #4179

stefan-korn opened this issue May 6, 2024 · 0 comments · May be fixed by #4180

Comments

@stefan-korn
Copy link
Contributor

The ComplexDataFacade for the Dataset is returning wrong empty values in the getArrayValues method I suppose.

If there is no value for the given property the values array is added by an empty array. This is not correct, the value should be skipped in that case.
In case there is a value (from preg_match) this is added to the values array and this is a string value (preg_match). So an empty array does not match a string value, an empty string would maybe be okay. But I think, the value should just be skipped in that case.

Describe the bug

I cannot give an indication whether this is somewhere making problems currently in DKAN. I came across this in #4115, where it poses an issue in some circumstances. Nonetheless I think the logic is generally not correct (string vs array) and it is not caused specifically by #4115.

Steps To Reproduce

no way (that I know of) to reproduce this in plain DKANv2

Expected behavior

@github-actions github-actions bot added this to Incoming/Triage in DKAN 2 Issue Triage May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
DKAN 2 Issue Triage
  
Incoming/Triage
Development

Successfully merging a pull request may close this issue.

1 participant