Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to activate trailing delimiter for CSV parser #4174

Open
stefan-korn opened this issue May 2, 2024 · 1 comment · May be fixed by #4175
Open

Allow to activate trailing delimiter for CSV parser #4174

stefan-korn opened this issue May 2, 2024 · 1 comment · May be fixed by #4175

Comments

@stefan-korn
Copy link
Contributor

stefan-korn commented May 2, 2024 •
edited

User Story

The csv paser library allows for a "traling delimiter" to be activated.

Currently it is not possible to activate this through the DKAN implementation.

Currently the parser configuration can be changed via ImportService::EVENT_CONFIGURE_PARSER, see #3864 .

It would be nice to be able to activate the trailing delimiter through this mechanism too.

Proposing to introduce a parser configuration setting for this. Setting this to FALSE by default , will not change the current behavior, but allow for changing via Event Subscriber if desired.

Acceptance Criteria

Trailing delimiter can be changed via ImportService::EVENT_CONFIGURE_PARSER.
@github-actions github-actions bot added this to Incoming/Triage in DKAN 2 Issue Triage May 2, 2024
stefan-korn added a commit to stefan-korn/dkan that referenced this issue May 2, 2024
@stefan-korn
GetDKAN#4174: Allow to activate trailing delimiter for CSV parser
3123b73
@stefan-korn stefan-korn linked a pull request May 2, 2024 that will close this issue
Open
4 tasks
@dafeder dafeder removed this from Incoming/Triage in DKAN 2 Issue Triage May 2, 2024
@dafeder
Copy link
Member

dafeder commented May 2, 2024

Sounds good. See PR comments.

stefan-korn added a commit to stefan-korn/dkan that referenced this issue May 3, 2024
@stefan-korn
GetDKAN#4174: Allow to activate trailing delimiter for CSV parser
7af75bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#4174: Allow to activate trailing delimiter for CSV parser stefan-korn/dkan
2 participants
@dafeder @stefan-korn