WidgetRouter accepts only PHP UUID

[larjohn]

I installed Drupal on a Windows machine and tried to add DKAN as a module manually. Other than the composer.json stuff that I had to add from the Docker template I found out that the metadata field is disabled by default. I tried enabling it, but it thew an exception:

Uncaught PHP Exception TypeError: "Drupal\json_form_widget\WidgetRouter::__construct(): Argument #1 ($uuid) must be of type Drupal\Component\Uuid\Php, Drupal\Component\Uuid\Com given"

It seems that the Com class is used in Windows installations of Drupal. Why not use the broader UuidInterface instead of Php in the WidgetRouter's constructor?

[dafeder]

Sounds reasonable! Are you able to submit a PR?

[larjohn]

Sounds reasonable! Are you able to submit a PR?

@janette was faster!

[janette]

@larjohn can you test that branch and let us know if that fixes the error.

[dafeder]

@larjohn @janette this just seems like it is more correct on its face and has no downsides so merging, but would still be interested in hearing that it did indeed fix the issue on Windows!

[larjohn]

Sorry for the delay, it did on my case Στάλθηκε από Outlook για Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Dan Feder ***@***.***> Sent: Thursday, November 30, 2023 9:06:14 PM To: GetDKAN/dkan ***@***.***> Cc: Lazaros Ioannidis ***@***.***>; Mention ***@***.***> Subject: Re: [GetDKAN/dkan] WidgetRouter accepts only PHP UUID (Issue #4064) @larjohn<https://github.com/larjohn> @janette<https://github.com/janette> this just seems like it is more correct on its face and has no downsides so merging, but would still be interested in hearing that it did indeed fix the issue on Windows! — Reply to this email directly, view it on GitHub<#4064 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAJ2WGOIRZVFMLXRSAR5FPTYHDKKNAVCNFSM6AAAAAA7SQIEA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZUGM4DQNJTGI>. You are receiving this because you were mentioned.Message ID: ***@***.***>