Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using the preview button, Date Modified requires a time to save #4045

Closed
dgading opened this issue Oct 26, 2023 · 0 comments · Fixed by #4046
Closed

When using the preview button, Date Modified requires a time to save #4045

dgading opened this issue Oct 26, 2023 · 0 comments · Fixed by #4046

Comments

@dgading
Copy link
Member

dgading commented Oct 26, 2023

Search existing issues to make sure the bug has not been reported already.

Describe the bug

When using the preview button and not setting a time for modified, you can see the preview and it has a time of 00:00:00 but when returning to the node edit for there is an error that a time is required. Adding a time is not required if the preview button isn't used and the node is saved first.

Steps To Reproduce

  1. Open a DKAN admin site with the preview button re-enabled.
  2. Create a new dataset
  3. Set just the date for the Modified field and all other required fields.
  4. Before saving, click the preview button
  5. On the preview page, click the back to dataset creation button
  6. You should now see the an error that a time is required
  7. Try to save the dataset and the error will prevent this action
  8. Set a time and successfully save

As a control, on the same site create a dataset and add a modified date with no time and save the dataset. It should save successfully and now you can preview it and come back and the error will not appear.

Expected behavior

A default time that is added during save is also added when using the preview button.

@github-actions github-actions bot added this to Incoming/Triage in DKAN 2 Issue Triage Oct 26, 2023
DKAN 2 Issue Triage automation moved this from Incoming/Triage to Closed Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant