Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultStorageManager has a misleading name #12160

Open
etj opened this issue Apr 15, 2024 · 1 comment
Open

DefaultStorageManager has a misleading name #12160

etj opened this issue Apr 15, 2024 · 1 comment
Assignees
@etj

Comments

@etj
Copy link
Contributor

etj commented Apr 15, 2024

DefaultStorageManager should be renamed as LocalStorageManager or FileSystemStorageManager, since "default" is about how it is chosen, not about what it does.
@giohappy
Copy link
Contributor

I agree @etj.
You can go ahead and rename it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etj etj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giohappy @etj