fix: docker nginx 404 error #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for geoguess2 pending review.Visit the deploys page to approve it
|
|
HelloJowet
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #751 +/- ##
=======================================
Coverage 52.12% 52.12%
=======================================
Files 53 53
Lines 752 752
Branches 209 209
=======================================
Hits 392 392
Misses 328 328
Partials 32 32 ☔ View full report in Codecov by Sentry. |
|
@all-contributors please add @HelloJowet for code |
|
I've put up a pull request to add @HelloJowet! 🎉 |
1 failed test on run #713 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| SinglePlayer > Play SinglePlayer Mode Country Time 10s |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #751 ↗︎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of Changes
Description
If I run the application with docker and try to access subdirectories like
/history, nginx returns a 404 error. I added a nginx configuration file to prevent this issue.Close #619
How Has This Been Tested?
After my changes I can now access subdirectories like
/historydirectly without any errors.